Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Add support for ArrayList #572

Merged
merged 3 commits into from
May 13, 2024

Conversation

ds8k
Copy link
Contributor

@ds8k ds8k commented May 10, 2024

Description

AdManagerAdRequest.Builder().addCustomTargeting supports passing both strings and ArrayLists. iOS already handles this.

Release Summary

  • Add support for string[] in customTargeting

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

iOS ad loaded with strings and string[] in customTargeting:
Screenshot 2024-05-10 at 2 58 04 PM

Android
Screenshot_20240510_152417_Axios

@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

@dylancom
Copy link
Collaborator

Thanks for your PR! I requested a small change :)

@ds8k
Copy link
Contributor Author

ds8k commented May 13, 2024

@dylancom made that change

@ds8k ds8k requested a review from dylancom May 13, 2024 16:09
@dylancom dylancom merged commit 7303730 into invertase:main May 13, 2024
6 of 10 checks passed
@dylancom
Copy link
Collaborator

Thanks for your contribution!

@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 13.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants