Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused file #615

Closed
wants to merge 1 commit into from

Conversation

DoctorJohn
Copy link
Contributor

Description

I always stumble across this file that I believe was commited by mistake since it does not contain real test, does not run as part of the test suite and is not referenced anywhere.

Test Plan

  • Tests still pass
  • Checked that file is not referenced anywhere

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (a34c7ba) to head (809c355).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   43.72%   43.26%   -0.45%     
==========================================
  Files          30       31       +1     
  Lines         549      571      +22     
  Branches      151      152       +1     
==========================================
+ Hits          240      247       +7     
- Misses        309      324      +15     

@dylancom
Copy link
Collaborator

I'm sure it hasn't been included by mistake, it's just currently unused.
Seems we have to add this to our tsconfig for type tests during compilation.
See: https://github.com/invertase/react-native-firebase/blob/c2c457608c865f6d25e4b9b6689cbc00721de194/tsconfig.json#L2C3-L2C69

(The origin where we extracted this package from)

@DoctorJohn
Copy link
Contributor Author

Closed in favor of #619

@DoctorJohn DoctorJohn closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants