Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify app.config.*s files are supported #625

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

DoctorJohn
Copy link
Contributor

@DoctorJohn DoctorJohn commented Aug 7, 2024

Description

This PR clarifies that app.config.js and app.config.ts files are still supported (just like app.json files).

This PR complements the app.json config examples with app.config.js and app.config.ts examples.

I was hoping we would not have to do this since it's somewhar cluttering the docs, but I tried to compensate that by using docs.page accordion components. Also tried using nested tabs, but they don't appear to be supported (i.e. they don't render correctly).

Related issues

Test Plan

Copy link

docs-page bot commented Aug 7, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~625

Documentation is deployed and generated using docs.page.

@dylancom
Copy link
Collaborator

dylancom commented Aug 9, 2024

Hmm I am a bit unsure if we need to add all this.

@DoctorJohn
Copy link
Contributor Author

Hmm I am a bit unsure if we need to add all this.

After sleeping another night over it I think the same. It shouldn't be our job to teach users about three different ways to create an expo config file. I'll remove the accordions and app.config.*s examples again and instead only mention the support for app.config.*s and maybe refer users to the expo docs. Does that sound good @dylancom ?

@dylancom
Copy link
Collaborator

Sounds good @DoctorJohn !

@DoctorJohn DoctorJohn changed the title docs: add app.config.js/ts examples docs: calrify app.config.*s files are supported Aug 18, 2024
@DoctorJohn DoctorJohn changed the title docs: calrify app.config.*s files are supported docs: clarify app.config.*s files are supported Aug 18, 2024
@dylancom dylancom merged commit 1bb9695 into invertase:main Aug 19, 2024
9 checks passed
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants