fix(firestore-stripe-payments): Address issue where insertInvoiceRecord function fails
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case where the Invoice has no associated Payment Intent, the Firestore collection write would fail. Fixes #505
jsteele-stripe
changed the title
insertInvoiceRecord function failsinsertInvoiceRecord function fails
jsteele-stripe
added a commit
that referenced
this pull request
Mar 20, 2023
In case where the Invoice has no associated Payment Intent, the Firestore collection write would fail. Fixes #505
jsteele-stripe
added a commit
that referenced
this pull request
Mar 20, 2023
* docs(firestore-stripe-payments): Fix GitHub links to `firestore-stripe-web-sdk` README * docs(firestore-stripe-payments): Reference Prices resource for restricted key instructions Fixes #477 * fix: Address issue where `insertInvoiceRecord` function fails (#511) In case where the Invoice has no associated Payment Intent, the Firestore collection write would fail. Fixes #505 * chore(deps): Bump `typescript` dependency (#512) * chore(firestore-stripe-payments): 0.3.3 release * chore: Bump `actions/checkout`, `actions/setup-node` versions for test workflows * chore: Bump `nick-invision/retry` version for test workflows --------- Co-authored-by: Darren Ackers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case where the Invoice has no associated Payment Intent, the Firestore collection write would fail.
This PR fixes this by deferring the the
invoice.idif no Payment Intent when writing to the Firestore collection.Fixes #505, #368