Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "feature" attribute to firestore product attribute #578

Open
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

huynhtk80
Copy link

createProductRecord will now also save feature attribute if it's not null. This was missing from the current function, which would be useful when creating pricing tables. "Feature" attribute is passed in the stripe webhook.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
All committers have signed the CLA.

@boskiv
Copy link

boskiv commented Nov 22, 2023

+1, need it in relase

@eddieespinal
Copy link

+1 on this. I need this feature right now for rendering the pricing table using the data in firebase but the features are missing. Please merge this PR if it's working properly. Thanks.

@pr-Mais
Copy link
Member

pr-Mais commented Jan 1, 2024

Hi @huynhtk80, thanks for your PR. It seems good to me, but I noticed the workflows aren't running, could you please check and update your PR.

The issue is having features as part of the Stripe.Product interface, which requires updating strip package.

@eddieespinal
Copy link

@huynhtk80 Hey, do you have time to address the issue pointed out by @pr-Mais? I would love to see this PR in production. Thanks.

@huynhtk80
Copy link
Author

huynhtk80 commented Jan 31, 2024

@pr-Mais Sorry for the delay, I've been busy with a new job, but will take closer look.

@huynhtk80
Copy link
Author

@pr-Mais I've created a pull request to update the Stripe package to update the type. As a temporary measure I've created a custom interface that extends Stripe.Product Not sure if that's an acceptable solution at this moment.

@o-glethorpe
Copy link

o-glethorpe commented Mar 26, 2024

Really need this. Cant really build price tables without showing features. And the option to build pricing tables from the dashboard does not seems to work with firebase.

@RideLikeTheWind
Copy link

Any chance this is able to be merged? Looking forward to this feature being included!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants