Fix: log Errors on winston ^2.3.1 #13
Conversation
rodrigo4244
force-pushed
the
rgo/fix-winston
branch
from
fbc3464
to
92873b9
Compare
helpers/cloneErrorProxy.js
Outdated
| @@ -0,0 +1,43 @@ | |||
| 'use strict' | |||
|
|
|||
| const LOGGING_LEVELS = [ | |||
There was a problem hiding this comment.
I copied LOGGING_LEVELS from src/helpers/assertLevel.js because this file is going to be deprecated when the bug is solved on winston.
There was a problem hiding this comment.
Make the above a code comment
rodrigo4244
force-pushed
the
rgo/fix-winston
branch
from
92873b9
to
fe3deda
Compare
index.js
Outdated
| transports, | ||
| }) | ||
|
|
||
| const logger = cloneErrorProxy(unwrappedLogger) |
There was a problem hiding this comment.
add a comment in this file as well as to why we're doing that
helpers/cloneErrorProxy.js
Outdated
| 'silly', | ||
| ] | ||
|
|
||
| // FIX: winston from 2.3.1 until 2.4.0 doesn't log Error objects. |
There was a problem hiding this comment.
did this comment miss the word "because" somewhere? i don't fully understand it.
|
clean approach! i just want two more comments ;) |
after winston solves its bug this PR gets deprecated
index.js
Outdated
| @@ -14,6 +14,9 @@ const unwrappedLogger = new (winston.Logger)({ | |||
| transports, | |||
| }) | |||
|
|
|||
| // We are proxying winston logger because versions from 2.3.0 until 2.4.0 | |||
| // does not log Error objects. The proxy is going to be DEPRECATED | |||
rodrigo4244
force-pushed
the
rgo/fix-winston
branch
from
5481d2f
to
95b5f2e
Compare
|
Should we have used this instead? |
|
This is pcool man! It will be an improvement to our system, we could even add the Add a new card to me and close this PR if you want me to patch |
|
@rodrigo4244 @kewitz you make a decision on what is best and report (share in the meeting) |
|
This is deprecated because of #14 The code is archived on the following tag: https://github.com/invisible-tech/logger/releases/tag/archive%2FcloneErrorProxy |
Description
This PR fixes the issue winstonjs/winston#1178 from
winstonusing a proxy on our logger.Test plan
mkdir /tmp/x;cd /tmp/x;npm init --yes)yarn add invisible-tech/logger#rgo/fix-winston)repro.jswithconst logger = require('@invisible/logger');logger.error(Error('Errors can be cool'))node repro.jsThe output is an error object "equals" to the one returned on
[email protected].It is not only the error message as on the card: https://trello.com/c/9p0K6DFe/776-logging-error-objects