Skip to content

Commit

Permalink
fix(ui): canvas sliders
Browse files Browse the repository at this point in the history
- Set an empty title to prevent browsers from showing "Please match the requested format." when hovering the number input
- Fix issue w/ `z-index` that prevented the popover button from being clicked while the input was focused
  • Loading branch information
psychedelicious committed Oct 9, 2024
1 parent 09b19e3 commit dd53660
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export const EntityListSelectedEntityActionBarOpacity = memo(() => {
clampValueOnBlur={false}
variant="outline"
>
<NumberInputField paddingInlineEnd={7} _focusVisible={{ zIndex: 0 }} />
<NumberInputField paddingInlineEnd={7} _focusVisible={{ zIndex: 0 }} title="" />
<PopoverTrigger>
<IconButton
aria-label="open-slider"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export const ToolBrushWidth = memo(() => {
onKeyDown={onKeyDown}
clampValueOnBlur={false}
>
<NumberInputField paddingInlineEnd={7} />
<NumberInputField _focusVisible={{ zIndex: 0 }} title="" paddingInlineEnd={7} />
<PopoverTrigger>
<IconButton
aria-label="open-slider"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export const ToolEraserWidth = memo(() => {
onKeyDown={onKeyDown}
clampValueOnBlur={false}
>
<NumberInputField paddingInlineEnd={7} />
<NumberInputField _focusVisible={{ zIndex: 0 }} title="" paddingInlineEnd={7} />
<PopoverTrigger>
<IconButton
aria-label="open-slider"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const CanvasToolbarScale = memo(() => {
onKeyDown={onKeyDown}
clampValueOnBlur={false}
>
<NumberInputField paddingInlineEnd={7} />
<NumberInputField paddingInlineEnd={7} title="" _focusVisible={{ zIndex: 0 }} />
<PopoverTrigger>
<IconButton
aria-label="open-slider"
Expand Down

0 comments on commit dd53660

Please sign in to comment.