Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat,fix,chore: canvas followups 5, release v5.0.0.a2 #6832

Merged
merged 10 commits into from
Sep 10, 2024
Merged

feat,fix,chore: canvas followups 5, release v5.0.0.a2 #6832

merged 10 commits into from
Sep 10, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Sep 10, 2024 •
edited
Loading

Summary

  • Fix: Drag over gallery/layers tab in right panel doesn't work
  • Fix: Translation string for gallery tab
  • Fix: Retain global canvas manager instance when its container unmounts (fixes issue with tool and canvas caches getting nuked when you change tabs)
  • Fix: Conflict hotkeys for brush size and layer cycle
  • Feat: Add count to layers tab
  • Feat: Add canvas context menu (so far only has actions to save bbox / send bbox to layer)
  • Chore: Bump UI library (fixes issue w/ stuck modifier keys if you alt-tab away from invoke while holding them down)
  • Internal: Clean up main canvas hook & container component

Also bumped version to v5.0.0.a2.

Related Issues / Discussions

Discord / offline discussion.

QA Instructions

Try the things mentioned

Merge Plan

I'll cut a2 release after merge

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@psychedelicious
fix(ui): drag image over tab switches to wrong tab
beb1756
@psychedelicious
fix(ui): translation string for gallery tab
eaf58ed
@psychedelicious
feat(ui): add count to layers tab button
c97a7d8
@psychedelicious
feat(ui): simplify canvas component & hook API
f80d87b
@psychedelicious
fix(ui): retain global canvas manager instance
0d8fac7 
To prevent losing all ephemeral canvas stage when switching tabs, we will refrain from destroying the canvas manager instance when its tab unmounts, and use the existing canvas manager instance on mount, if there is one.

One small change required in `CanvasStageModule` - a `setContainer` method to update the konva stage DOM element.
@psychedelicious
chore(ui): bump @invoke-ai/ui-library
d8f4c69 
Fixes an issue where modifier keys get stuck on when you change tabs or windows.
@psychedelicious
feat(ui): add canvas context menu
e896249 
So far, this includes:
- Save Canvas to Gallery
- Save Bbox to Gallery
- Send Bbox to Regional IP Adapter
- Send Bbox to Global IP Adapter
- Send Bbox to Control Layer
- Send Bbox to Raster Layer
@psychedelicious
chore: release v5.0.0.a2
b0c3b2c
@psychedelicious
fix(ui): do not show count on layers tab when no layers
2d2e492
@github-actions github-actions bot added python PRs that change python files frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Sep 10, 2024
@hipsterusername hipsterusername enabled auto-merge (rebase) September 10, 2024 13:14
@hipsterusername hipsterusername merged commit f82640b into main Sep 10, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/canvas-followups-5 branch September 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@lstein lstein Awaiting requested review from lstein lstein is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername