Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): viewer UX #6842

Merged
merged 12 commits into from
Sep 12, 2024
Merged

feat(ui): viewer UX #6842

merged 12 commits into from
Sep 12, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Sep 12, 2024 •
edited
Loading

Summary

  • Restore image viewer on canvas w/ revised UX
  • Remove gallery tab
  • Restore the send-to switch near invoke button
  • Display alert on canvas when sending to gallery, display alert on viewer when sending to canvas, may be disabled w/ button on the alert and toggled in settings
  • Toast after image generation if user is not looking at the selected send to destination, may be disabled w/ button on the toast & toggled in settings
  • Toast when toggling send to

Related Issues / Discussions

n/a

QA Instructions

Try it out.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@psychedelicious
build(ui): bump @invoke-ai/ui-library
01f93b3 
This gets us access to the Alert component.
@psychedelicious
fix(ui): select first image instead of clearing selection fully
2677556 
Fixes an issue where you end up w/ the no image fallback after pressing escape.
@psychedelicious
feat(ui): use <Alert/> for selected entity alerts
66eabc1
@psychedelicious
feat(ui): restore viewer
6ba0deb 
- Remove gallery tab
- Restore viewer
- Add configurable alerts & toasts when user may be lost
@github-actions github-actions bot added frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Sep 12, 2024
@psychedelicious
Copy link
Collaborator Author

  • Juiced alert animations
  • Reverted post-generation toasts
  • Made alerts show only when current generation is going to a different view
  • Added missing translation

@psychedelicious psychedelicious enabled auto-merge (rebase) September 12, 2024 13:29
@psychedelicious psychedelicious enabled auto-merge (rebase) September 12, 2024 13:41
@psychedelicious psychedelicious merged commit 1a59887 into main Sep 12, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/viewer-ux branch September 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername