Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): bbox stuff #6897

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix(ui): bbox stuff #6897

merged 3 commits into from
Sep 20, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Sep 20, 2024 •
edited
Loading

Summary

  • Save the original bbox dimensions in metadata instead of scaled dimensions
  • Hide scaled w/h sliders when scaling is disabled
  • Prevent invoking when FLUX model is selected w/ incompatible bbox size

Related Issues / Discussions

Reported: https://discord.com/channels/1020123559063990373/1149506274971631688/1286628239015411712

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 20, 2024
@psychedelicious psychedelicious changed the title fix(ui): bbox metadata & hide disabled scaling sliders fix(ui): bbox stuff Sep 20, 2024
@hipsterusername hipsterusername merged commit e690364 into main Sep 20, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/fix/bbox-metadata branch September 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername