Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) fixed bbox size reset to optimals on 'Use All' (Asterisk) button press #6915

Merged

Conversation

FloeHetling
Copy link
Contributor

Summary

This PR addresses a problem when user commands to recall all metadata from the generated image. While recalling only partial metadata everything works fine, but 'Use All' aka the Asterisk button resets state of canvas bbox to model optimal dimensions.

RC1_UX_mishaps.mp4

Related Issues / Discussions

QA Instructions

  • Generate a sample image with dimensions other than defaults for the selected model.
  • Perform WebUI reset and localStorage.clear(), clear cache, reload CanvasV2 Viewer.
  • Use Asterisk (Use All) command to recall all generation parameters from the generated image.
  • Invoke a new image using recalled parameters.
  • Sample image and newly-generated one should be the same.

Merge Plan

Checklist

  • [ + ] The PR has a short but descriptive title, suitable for a changelog
  • [ N/A ] Tests added / updated (if applicable)
  • [ N/A ] Documentation added / updated (if applicable)

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psychedelicious psychedelicious enabled auto-merge (rebase) September 23, 2024 07:57
@psychedelicious psychedelicious merged commit 967c561 into invoke-ai:main Sep 23, 2024
14 checks passed
@FloeHetling FloeHetling deleted the floehetling/fix/recall-all branch September 23, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants