feat(ui): show CLIP Vision models in model manager UI #6994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why they were hidden but it makes it hard to delete them if they are borked for some reason (have to go thru API docs page or do DB surgery).
For example, CLIP Vision models have no settings.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
blessedcoolant
approved these changes
Oct 1, 2024
hipsterusername
approved these changes
Oct 1, 2024
|
We may want to rationalize these at some point so people can differentiate and better organize the models, but does make sense to show all models even if they’re “support” in nature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not sure why they were hidden but it makes it hard to delete them if they are borked for some reason (have to go thru API docs page or do DB surgery).
Related Issues / Discussions
QA Instructions
Should be able to see and delete CLIP vision models in the MM tab
Merge Plan
n/a
Checklist