fix(ui): FLUX IP adapter clip vision model error #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Nov 7, 2024
psychedelicious
force-pushed
the
psyche/fix/ui/flux-ip-adapter-clip
branch
from
bd45e2f
to
f3553ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a reference image (global or regional) we were not setting the CLIP vision model correctly. As a result, FLUX IP Adapters, which require the
ViT-Lmodel, were causing errors.This situation is now handled.
Also, when graph building fails, we now display an error toast. Previously, there was no feedback at all, so it felt like the invoke button just did nothing.
Related Issues / Discussions
offline discussion
QA Instructions
This won't fix existing misconfigured IP Adapters, but it does prevent new ones from ending up with the wrong CLIP vision model selection.
Merge Plan
n/a
Checklist