feat(ui): update warnings on upscaling tab based on model arch #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Nov 8, 2024
psychedelicious
force-pushed
the
psyche/feat/ui/upscaling-tab-model-compat
branch
from
fcc95af
to
96664fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an unsupported model architecture is selected, show that warning only, without the extra warnings (i.e. no "missing tile controlnet" warning)
Update Invoke tooltip warnings accordingly
Related Issues / Discussions
Closes #7239
Closes #7177
QA Instructions
You won't be able to choose FLUX or SD3.5 models when on the upscaling tab - but you can from the canvas tab. Choose one of those model types for your main model, then go to the upscaling tab.
You should get a message about unsupported model architecture instead of a misleading message about missing the tile upscaling model. Also, the invoke button tooltip should warn about incompatible model.
Merge Plan
n/a
Checklist