Replaced extension logo parameter with banner toggle

[jlstevens]

This simple PR replaces the logo option of the notebook extension (which only toggled the logo) with a banner switch with can suppress both the logo and the loading message. Addresses #1186.

We'll need to mention the replacement of the logo parameter in the CHANGELOG but I don't think it is a big deal - the new behavior simply extends the old behavior and I don't think the logo parameter was used much anyway.

[jbednar]

Thanks. Will this still print a blank line, or will it avoid printing at all (preferred)?

[jlstevens]

Thanks. Will this still print a blank line, or will it avoid printing at all (preferred)?

I noticed a tiny it more whitespace than normal (i.e more than when you just enter None into a cell) but didn't manage to remove it, even after simplifying the template to just JS. Here is what I mean:

I assume this odd effect happens when there is JS code 'displayed' even though nothing should be visible (including that slightly larger white gap).

[jbednar]

I'm not so worried about what happens if the notebook_extension() call is the last line in the cell, but what happens if I then put some useful things with real output at the end of that same cell (e.g. "2.0") -- will the formatting then be messed up?

[philippjfr]

I'm not so worried about what happens if the notebook_extension() call is the last line in the cell, but what happens if I then put some useful things with real output at the end of that same cell (e.g. "2.0") -- will the formatting then be messed up?

No, it'll behave as now and just put that bit of whitespace above your figure.

[philippjfr]

Ready to merge?

[jlstevens]

Yup, I think so.

[jbednar]

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.