treat isolated_build as an alias for wheel_pep517 #6
Conversation
the isolated_build flag is documented as enabling pep517 already: Activate isolated build environment. tox will use a virtual environment to build a source distribution from the source tree. For build tools and arguments use the pyproject.toml file as specified in PEP-517 and PEP-518.
| reporter.warning("Disabling isolated_build, not supported with wheels.") | ||
| pep517 = venv.envconfig.wheel_pep517 | ||
| if pep517: | ||
| if config.isolated_build or venv.envconfig.wheel_pep517: |
There was a problem hiding this comment.
I typoed this and didn't notice:
https://github.com/twisted/ldaptor/pull/180/files#diff-522adf759addbd3b193c74ca85243f7dR31
There was a problem hiding this comment.
Why did I put that warning I wonder ...
@ionelmc I'm not sure, it seems sensible to me to process the flag for its stated purpose rather than claim to disable it while not disabling it
There was a problem hiding this comment.
I presume the warning predates wheel_pep517?
|
Why did I put that warning I wonder ... |
|
Alright. I guess I put it there because isolated_builds don't work with the legacy wheel building, nor it makes sense. |
|
Actually, now that I think a bit this is wrong - having a plugin installed shouldn't change behavior if there wasn't any opt-in the configuration (eg: wheel=true). Might need to revert this to prevent surprising behavior. @graingert |
|
@ionelmc this doesn't trigger without |
the isolated_build flag is documented as enabling pep517 already: Activate isolated build environment. tox will use a virtual environment to build a source distribution from the source tree. For build tools and arguments use the pyproject.toml file as specified in PEP-517 and PEP-518.