fix: pwa icon generation and angular vue path #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes WN-1459
When
npx @capacitor/assets generate --pwais run with an angular or vue project it looks insrc/assets/assetsfolder but the default path for angular and vue assets is justsrc/assets.This also replaces any icons in the
manifest.webmanifestfile (it would previously only change an icon if the filename existed already in the file.Note: also reduced the linting errors
This should also fix #568 which is a side effect of not choosing the path correctly in an Angular or Vue project.
Also fixes #520 which is caused by it checking for icons by their filename rather than their size.