Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local-notifications): Showing correct scheduled notification time #1198

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

theproducer
Copy link
Contributor

Fixes an issue where on and every notification schedules did not show the current notification time.

closes: #433

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add extra parameters to the Intent. On TimedNotificationPublisher you can get the original notification including the schedule.

But I don't think that's even needed, I think calling notification.when = System.currentTimeMillis(); in TimedNotificationPublisher should cover all cases, for on, every and at, so we can even remove the current code for handling the at and that single line should show the correct time for all of them.

@jcesarmobile jcesarmobile merged commit 96c5430 into main Sep 29, 2022
@jcesarmobile jcesarmobile deleted the local-notification-android-showtime branch September 29, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: show time of when the notifications is launched and not when it was scheduled
3 participants