feat(camera): only request permission to save to the gallery for Android <= 9 #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9 (API 28) Context: For Android >= 10, we don't need to request permissions to save the photo to the gallery. More info here: https://developer.android.com/media/camera/camera-deprecated/photobasics#TaskPath References: https://outsystemsrd.atlassian.net/browse/RMET-3767
|
Released dev build of camera with dev version: 7.0.0-dev-2222-20241024T153427.0 |
alexgerardojacinto
requested review from
a team,
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
OS-ricardomoreirasilva
approved these changes
Oct 24, 2024
camera/android/src/main/java/com/capacitorjs/plugins/camera/CameraPlugin.java
Outdated
Show resolved
Hide resolved
IT-MikeS
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug on @capacitor/camera on Android, where when taking a photo with
saveToGallery = true, the camera only opened on the second attempt because of the permission to save to the gallery not being given.This only happened for Android >= 10, and for those versions, we don't even need to request for permission to save to the gallery. More info here.
Closes #2210
References: https://outsystemsrd.atlassian.net/browse/RMET-3767