-
Notifications
You must be signed in to change notification settings - Fork 109
Docs: update to reflect logging configuration changes #258
Conversation
This pull request is being automatically deployed with Vercel (learn more). capacitor-site – ./🔍 Inspect: https://vercel.com/ionic/capacitor-site/Dad2uCsmhGWvUA7CAVSVJJvFEvwE [Deployment for 0febb7e failed] capacitor-docs – ./🔍 Inspect: https://vercel.com/ionic/capacitor-docs/D4ijW7xpUHdeyms66AoksCj6V7LM [Deployment for 0335ae7 failed] capacitor-site-ionic-io – ./🔍 Inspect: https://vercel.com/ionic/capacitor-site-ionic-io/8jr8bj9hRnDVT53pn22gHqsFFBm8 [Deployment for 0febb7e failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config changes should be done on the v3 config docs, you made them on the v2 ones.
Same for console API, but I've noticed that we don't have a console section on v3 (probably because they are now generated from plugins and Console is not a real plugin)
This reverts commit 897cf59.
Whoops, good catch. Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Not sure if we might want to leave the hideLogs as it's still there despite it's deprecated, or if it's better to remove it so people don't use it.
We might want to document in the capacitor 3 upgrade guide that hideLogs
is deprecated and that they should move to loggingBehavior
Updated the upgrade guide. |
Documentation companion to ionic-team/capacitor#4416