fix(cli): Warn if core version doesn't match platform version (#2736)

ionic-team · Apr 10, 2020 · 29a9acf · 29a9acf
1 parent 3baf81b
commit 29a9acf
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/cli/src/common.ts b/cli/src/common.ts
@@ -405,13 +405,12 @@ export async function getPlatformVersion(config: Config, platform: string): Prom
 }
 
 export async function checkPlatformVersions(config: Config, platform: string) {
-  const cliVersion = await getCLIVersion(config);
+  const coreVersion = await getCoreVersion(config);
   const platformVersion = await getPlatformVersion(config, platform);
-
-  if (semver.gt(cliVersion, platformVersion)) {
+  if (semver.diff(coreVersion, platformVersion) === 'minor' || semver.diff(coreVersion, platformVersion) === 'major') {
     log('\n');
-    logInfo(`Your @capacitor/cli version is greater than @capacitor/${platform} version`);
-    log(`Consider updating to matching version ${chalk`{bold npm install @capacitor/${platform}@${cliVersion}}`}`);
+    logWarn(`Your @capacitor/core version doesn't match your @capacitor/${platform} version`);
+    log(`Consider updating to matching version ${chalk`{bold npm install @capacitor/core@${platformVersion}}`}`);
   }
 }