fix(cli): correctly build and sign Android apps using Flavors (#7082)

Co-authored-by: Mark Anderson <[email protected]> Co-authored-by: jcesarmobile <[email protected]>
ionic-team · Jan 18, 2024 · 7d3a99d · 7d3a99d
1 parent 4a02e7a
commit 7d3a99d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/cli/src/android/build.ts b/cli/src/android/build.ts
@@ -35,17 +35,25 @@ export async function buildAndroid(
     }
   }
 
+  const releaseDir = releaseTypeIsAAB
+    ? flavor !== ''
+      ? `${flavor}Release`
+      : 'Release'
+    : flavor !== ''
+    ? join(flavor, 'release')
+    : 'release';
+
   const releasePath = join(
     config.android.appDirAbs,
     'build',
     'outputs',
     releaseTypeIsAAB ? 'bundle' : 'apk',
-    buildOptions.flavor ? `${flavor}Release` : 'release',
+    releaseDir,
   );
 
-  const unsignedReleaseName = `app${
-    config.android.flavor ? `-${config.android.flavor}` : ''
-  }-release${releaseTypeIsAAB ? '' : '-unsigned'}.${releaseType.toLowerCase()}`;
+  const unsignedReleaseName = `app${flavor !== '' ? `-${flavor}` : ''}-release${
+    releaseTypeIsAAB ? '' : '-unsigned'
+  }.${releaseType.toLowerCase()}`;
 
   const signedReleaseName = unsignedReleaseName.replace(
     `-release${

diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -174,6 +174,7 @@ export function runProgram(config: Config): void {
             platform,
             {
               scheme,
+              flavor,
               keystorepath,
               keystorepass,
               keystorealias,
@@ -185,6 +186,7 @@ export function runProgram(config: Config): void {
             const { buildCommand } = await import('./tasks/build');
             await buildCommand(config, platform, {
               scheme,
+              flavor,
               keystorepath,
               keystorepass,
               keystorealias,