fix(android): plugin retained events not being retained if listeners …

…were empty (#2408)
ionic-team · Mar 5, 2020 · 7decd0b · 7decd0b
1 parent cf2f746
commit 7decd0b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/Plugin.java b/android/capacitor/src/main/java/com/getcapacitor/Plugin.java
@@ -300,7 +300,7 @@ public void pluginRequestPermission(String permission, int requestCode) {
    */
   private void addEventListener(String eventName, PluginCall call) {
     List<PluginCall> listeners = eventListeners.get(eventName);
-    if (listeners == null) {
+    if (listeners == null || listeners.isEmpty()) {
       listeners = new ArrayList<PluginCall>();
       eventListeners.put(eventName, listeners);
 
@@ -335,7 +335,7 @@ private void removeEventListener(String eventName, PluginCall call) {
   protected void notifyListeners(String eventName, JSObject data, boolean retainUntilConsumed) {
     Log.v(getLogTag(), "Notifying listeners for event " + eventName);
     List<PluginCall> listeners = eventListeners.get(eventName);
-    if (listeners == null) {
+    if (listeners == null || listeners.isEmpty()) {
       Log.d(getLogTag(), "No listeners found for event " + eventName);
       if (retainUntilConsumed) {
         retainedEventArguments.put(eventName, data);