Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): plugin retained events not being retained if listeners were empty #2408

Merged
merged 2 commits into from
Feb 6, 2020
Merged

fix(android): plugin retained events not being retained if listeners were empty #2408

merged 2 commits into from
Feb 6, 2020

Conversation

kofoeddk
Copy link
Contributor

@kofoeddk kofoeddk commented Feb 5, 2020 •
edited by jcesarmobile
Loading

Fixes: #2404

@kofoeddk kofoeddk mentioned this pull request Feb 5, 2020
Closed
4 tasks
@jcesarmobile jcesarmobile changed the title Extend listener checks when adding and notifying fix(android): retained events not fired if listeners were empty Feb 6, 2020
jcesarmobile
jcesarmobile approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jcesarmobile jcesarmobile changed the title fix(android): retained events not fired if listeners were empty fix(android): plugin retained events not being retained if listeners were empty Feb 6, 2020
@jcesarmobile jcesarmobile merged commit b817e83 into ionic-team:master Feb 6, 2020
priyankpat pushed a commit to priyankpat/capacitor that referenced this pull request Feb 13, 2020
@kofoeddk @priyankpat
fix(android): plugin retained events not being retained if listeners …
5c6d6aa 
…were empty (ionic-team#2408)
chrisweight added a commit to chrisweight/capacitor that referenced this pull request Feb 17, 2020
@chrisweight
Merge remote-tracking branch 'upstream/master'
de72bcd 
* upstream/master: (50 commits)
  feat(Device): Add getBatteryInfo function (ionic-team#2435)
  fix(doctor): add electron checks (ionic-team#2434)
  chore(android): target SDK version 29 (ionic-team#2433)
  feat(android): update gradle and dependencies (ionic-team#2431)
  fix(ios): Make Clipboard plugin return errors (ionic-team#2430)
  feat(android): Handle onDestroy lifecycle event in plugins (ionic-team#2421)
  docs(ce-plugins): Remove or replace deprecated plugins (ionic-team#2419)
  feat(ios): change native location accuracy values (ionic-team#2420)
  docs(ce-guides): Remove dead link (ionic-team#2418)
  docs(network): Remove example guide because of dead link (ionic-team#2417)
  feat(electron): Remove injectCapacitor function (ionic-team#2415)
  fix(android): plugin retained events not being retained if listeners were empty (ionic-team#2408)
  chore(android): remove unused launch_splash.xml (ionic-team#2411)
  feat(Filesystem): Remove createIntermediateDirectories from MkdirOptions (ionic-team#2410)
  feat(android): use Fused Location Provider on Geolocation plugin (ionic-team#2409)
  fix(toast): unify duration across platforms (ionic-team#2340)
  feat(PushNotifications): Make register method return if permission was granted (ionic-team#2324)
  chore(circleci): update Xcode and remove install-cocoapods job (ionic-team#2402)
  chore(cli): fix tests for newer node versions (ionic-team#2403)
  fix(android): return original camera image if edition was canceled (ionic-team#2358)
  ...
nphyatt pushed a commit that referenced this pull request Mar 5, 2020
@kofoeddk @nphyatt
fix(android): plugin retained events not being retained if listeners …
e9a9ebb 
…were empty (#2408)
@nphyatt nphyatt mentioned this pull request Mar 5, 2020
Merged
jcesarmobile pushed a commit that referenced this pull request Mar 5, 2020
@kofoeddk @jcesarmobile
fix(android): plugin retained events not being retained if listeners …
7decd0b 
…were empty (#2408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: notifyListeners() only works for the first call
2 participants
@kofoeddk @jcesarmobile