Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove electron platform #3140

Closed
imhoffd opened this issue Jun 23, 2020 · 4 comments · Fixed by #3291
Closed

Remove electron platform #3140

imhoffd opened this issue Jun 23, 2020 · 4 comments · Fixed by #3291
Assignees
Milestone

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Jun 23, 2020

The provided electron platform needs to be removed from the repo and the CLI (and wherever else).

@imhoffd imhoffd added this to the 3.0.0 milestone Jun 23, 2020
imhoffd added a commit that referenced this issue Jun 30, 2020
imhoffd added a commit that referenced this issue Jun 30, 2020
@imhoffd imhoffd self-assigned this Jun 30, 2020
imhoffd added a commit that referenced this issue Jul 7, 2020
imhoffd added a commit that referenced this issue Jul 14, 2020
imhoffd added a commit that referenced this issue Jul 16, 2020
imhoffd added a commit that referenced this issue Jul 16, 2020
imhoffd added a commit that referenced this issue Jul 16, 2020
kheftel pushed a commit to kheftel/capacitor that referenced this issue Jul 22, 2020
@Berkmann18
Copy link

Berkmann18 commented Aug 9, 2020

Is there a reason why @capacitor/[email protected] still uses that electron platform and yet prints (upon running cap doctor electron on a fresh Capacitor project)

[success] electron looking great! 👌
[warn] The electron platform is deprecated!

?
I'm confused as to why the latest version does that when I suppose it would have used the right platform.

Side (unrelated) note: the help menu is printed twice when unknown commands (e.g. cap help) are passed.

@imhoffd
Copy link
Contributor Author

imhoffd commented Aug 12, 2020

I'm not sure I understand the question, but the Electron platform is deprecated in 2.x and will be removed in Capacitor 3. We're not going to remove it in 2.4 or any future 2.x release because it would be a breaking change.

@Berkmann18
Copy link

That makes sense, it just odd.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants