-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Filesystem): Add move implementation #1624
feat(Filesystem): Add move implementation #1624
Conversation
This also merges in other dependent branches, as those changes are needed for this branch to work correctly. |
5c84dc0
to
3362fda
Compare
3362fda
to
4bc9e44
Compare
Thanks! Given that we're trying to follow node's API for fs, should we call this |
Sure thing, I have changed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The only concern I have is that it doesn't allow to move to a different directory type (i.e. from FilesystemDirectory.Documents
to FilesystemDirectory.Data
), just inside the same type.
But that can be improved in a future release.
Implementation for all platforms, and uses the same move semantics across all.
It also preserves mtime across all platforms for both files and directories, (ctime is not available in some platforms, or is inconsistently handled by the underlying filesystem).
Moving a file to a directory does not imply moving it into that directory (ie "mv " does not imply "mv /" and will fail