Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): drop Xcode 10 support #2472

Merged
merged 1 commit into from
Feb 24, 2020
Merged

chore(ios): drop Xcode 10 support #2472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios-template/App/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
platform :ios, '11.0'
use_frameworks!

# workaround to avoid Xcode 10 caching of Pods that requires
# workaround to avoid Xcode caching of Pods that requires
# Product -> Clean Build Folder after new Cordova plugins installed
# Requires CocoaPods 1.6 or newer
install! 'cocoapods', :disable_input_output_paths => true
Expand Down
5 changes: 3 additions & 2 deletions ios/Capacitor/Capacitor/CAPBridgeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,9 @@ public class CAPBridgeViewController: UIViewController, CAPBridgeDelegate, WKScr
if let statusBarStyle = plist["UIStatusBarStyle"] as? String {
if (statusBarStyle == "UIStatusBarStyleDarkContent") {
if #available(iOS 13.0, *) {
// TODO - use .darkContent instead of rawValue once Xcode 10 support is dropped
self.statusBarStyle = UIStatusBarStyle.init(rawValue: 3) ?? .default
self.statusBarStyle = .darkContent
} else {
self.statusBarStyle = .default
}
} else if (statusBarStyle != "UIStatusBarStyleDefault") {
self.statusBarStyle = .lightContent
Expand Down
3 changes: 1 addition & 2 deletions ios/Capacitor/Capacitor/Plugins/StatusBar.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ public class CAPStatusBarPlugin: CAPPlugin {
bridge.setStatusBarStyle(.lightContent)
} else if style == "LIGHT" {
if #available(iOS 13.0, *) {
// TODO - use .darkContent instead of rawValue once Xcode 10 support is dropped
bridge.setStatusBarStyle(UIStatusBarStyle.init(rawValue: 3) ?? .default)
bridge.setStatusBarStyle(.darkContent)
} else {
bridge.setStatusBarStyle(.default)
}
Expand Down
2 changes: 1 addition & 1 deletion site/docs-md/basics/opening-native-projects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ contributors:

<p class="intro">Capacitor uses the native IDE for each platform in order to provide required configuration, and to build, test, and deploy apps.</p>

<p class="intro">For iOS development, that means you must have <a href="https://developer.apple.com/xcode/" target="_blank">Xcode 10</a> or above installed. For Android, <a href="https://developer.android.com/studio/index.html" target="_blank">Android Studio</a> 3 or above.</p>
<p class="intro">For iOS development, that means you must have <a href="https://developer.apple.com/xcode/" target="_blank">Xcode 11</a> or above installed. For Android, <a href="https://developer.android.com/studio/index.html" target="_blank">Android Studio</a> 3 or above.</p>

<p class="intro">Both IDEs can be opened manually or using the <code>npx cap open</code> command:</p>

Expand Down
2 changes: 1 addition & 1 deletion site/docs-md/getting-started/dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ For specific platforms, follow each guide below to ensure you have the correct d

## iOS Development

For building iOS apps, Capacitor requires a **Mac with Xcode 10 or above**. Soon, you'll be able to use [Ionic Appflow](http://ionicframework.com/appflow) to build for iOS even if you're on Windows.
For building iOS apps, Capacitor requires a **Mac with Xcode 11 or above**. Soon, you'll be able to use [Ionic Appflow](http://ionicframework.com/appflow) to build for iOS even if you're on Windows.

Additionally, you'll need to install **[CocoaPods](https://cocoapods.org/)** (`sudo gem install cocoapods`), and install the **Xcode Command Line tools** (either from Xcode, or running `xcode-select --install`).

Expand Down
2 changes: 1 addition & 1 deletion site/docs-md/guides/push-notifications-firebase.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ Your `Podfile` should look something like this:
platform :ios, '11.0'
use_frameworks!

# workaround to avoid Xcode 10 caching of Pods that requires
# workaround to avoid Xcode caching of Pods that requires
# Product -> Clean Build Folder after new Cordova plugins installed
# Requires CocoaPods 1.6 or newer
install! 'cocoapods', :disable_input_output_paths => true
Expand Down
2 changes: 1 addition & 1 deletion site/docs-md/ios/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ contributors:

## Getting Started

Building iOS apps requires some iOS development dependencies to be installed, including Xcode 10 and the Xcode command line tools.
Building iOS apps requires some iOS development dependencies to be installed, including Xcode 11 and the Xcode command line tools.

Note: It's possible to develop and build iOS apps without a mac, such as by using Ionic Appflow's Package service. Consult your service of choice for more information.

Expand Down