Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LocalNotifications): Allow to create notifications without activity #2648

Merged
merged 2 commits into from
Apr 3, 2020
Merged

feat(LocalNotifications): Allow to create notifications without activity #2648

merged 2 commits into from
Apr 3, 2020

Conversation

dwlrathod
Copy link
Contributor

@dwlrathod dwlrathod commented Mar 27, 2020 •
edited by jcesarmobile
Loading

Fixes #2626

@BorntraegerMarc
Copy link

Fixes #2626

@jcesarmobile jcesarmobile self-requested a review April 3, 2020 14:21
@jcesarmobile jcesarmobile mentioned this pull request Apr 3, 2020
Open
@jcesarmobile jcesarmobile changed the title fixed #2626 feat(LocalNotifications): Allow to create notifications without activity Apr 3, 2020
jcesarmobile
jcesarmobile approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to use it, but doesn't seem to break regular notifications, so merging

@jcesarmobile jcesarmobile merged commit a4e5918 into ionic-team:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(LocalNotification): ability to generate localNotification when app is in background (from service)
3 participants
@dwlrathod @BorntraegerMarc @jcesarmobile