feat: Allow plugins to override navigation #2872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variation of #2307
changes:
Android method renamed from
shouldOpenExternalUrl
toshouldOverrideLoad
(more similar to the Android WebView method, and matches the iOS name). Logic changes, false load, true abort, null default.ios method renamed from
shouldOverrideLoadWith
toshouldOverrideLoad
, with a singleWKNavigationAction
param instead of two (you can get both request and navigationType from it).Method return type changed from Bool to NSNumber so it can return nil.
And as it can return nil now, change logic to work as on Android (false load, true abort, nil default)
closes #2307
closes #70