docs(deep-links): clarify apple-app-site-association file #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydrogers
changed the title
apple-app-site-associationapple-app-site-association file
jaydrogers
changed the title
apple-app-site-association fileapple-app-site-association file
jaydrogers
changed the title
apple-app-site-association fileapple-app-site-association file
|
Oh, nooooooo sorry Jay! I intended those comments to be illustrative/helpful. Had no idea that would happen, but makes sense. The main issue is that Apple should accept a file extension (.json) - then this wouldn't happen.... Well, thank you so much for opening a PR. Really appreciate it! |
|
Hahaha, no problem. I 100% agree about Apple just needs to accept Thanks again for all of your hard work. You guys are building amazing things! |
jcesarmobile
approved these changes
May 22, 2020
jcesarmobile
changed the title
apple-app-site-association file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with the
apple-app-site-associationfile today, banging my head against the wall why it wasn't working.Then I realized there was a comment at the top of the file that was causing my file to be interpreted as a file to be downloaded (not a content-type of JSON). LOL, programming...
I created this PR to hopefully help clarify the example a little bit more and prevent others from running into the same issue (although I know I am the dumb one 😀)
Thanks for your hard work 🙏
Let me know if you have any questions!