Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add core to CI tests #3094

Merged
merged 2 commits into from
Jun 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,26 @@ jobs:
- run: npm run build
- run: npm run lint
- run: npm test
test-core:
runs-on: ubuntu-latest
timeout-minutes: 30
defaults:
run:
working-directory: ./core
steps:
- uses: actions/setup-node@v1
with:
node-version: 14.x
- uses: actions/checkout@v2
- name: Restore Dependency Cache
uses: actions/cache@v1
with:
path: ~/.npm
key: ${{ runner.OS }}-dependency-cache-${{ hashFiles('**/package.json') }}
- run: npm install
- run: npm run build
- run: npm run lint
- run: npm test
test-ios:
runs-on: macos-latest
timeout-minutes: 30
Expand Down
10 changes: 5 additions & 5 deletions core/src/core-plugin-definitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export interface AppRestoredResult {
*/
error?: {
message: string;
}
};
}

//
Expand Down Expand Up @@ -1104,7 +1104,7 @@ export interface LocalNotification {
/**
* Android only: set the color of the notification icon
*/
iconColor?: string
iconColor?: string;
attachments?: LocalNotificationAttachment[];
actionTypeId?: string;
extra?: any;
Expand All @@ -1127,8 +1127,8 @@ export interface LocalNotification {
*/
groupSummary?: boolean;
/**
* Android only: set the notification channel on which local notification
* will generate. If channel with the given name does not exist then the
* Android only: set the notification channel on which local notification
* will generate. If channel with the given name does not exist then the
* notification will not fire. If not provided, it will use the default channel.
*/
channelId?: string;
Expand Down Expand Up @@ -1602,7 +1602,7 @@ export interface NotificationChannelList {
export interface PushNotificationsPlugin extends Plugin {
/**
* Register the app to receive push notifications.
* Will trigger registration event with the push token
* Will trigger registration event with the push token
* or registrationError if there was some problem.
* Doesn't prompt the user for notification permissions, use requestPermission() first.
*/
Expand Down
2 changes: 1 addition & 1 deletion core/src/web/clipboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class ClipboardPluginWeb extends WebPlugin implements ClipboardPlugin {
const blob = await (await fetch(options.image)).blob();
const clipboardItemInput = new ClipboardItem({[blob.type] : blob});
await navigator.clipboard.write([clipboardItemInput]);
}catch(err) {
} catch (err) {
return Promise.reject('Failed to write image');
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions core/src/web/local-notifications.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ export class LocalNotificationsPluginWeb extends WebPlugin implements LocalNotif
platforms: ['web']
});
}

createChannel(channel: NotificationChannel): Promise<void> {
throw new Error('Feature not available in the browser. ' + channel.id);
}

deleteChannel(channel: NotificationChannel): Promise<void> {
throw new Error('Feature not available in the browser. ' + channel.id);
}

listChannels(): Promise<NotificationChannelList> {
throw new Error('Feature not available in the browser');
}
Expand Down