Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): replace SDK variables with default values on Cordova plugins #3525

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix(cli): replace SDK variables with default values on Cordova plugins #3525

merged 1 commit into from
Sep 8, 2020

Conversation

jcesarmobile
Copy link
Member

closes #3517

@jcesarmobile jcesarmobile merged commit 090427a into ionic-team:2.x Sep 8, 2020
@jcesarmobile jcesarmobile deleted the variable-replace-podspec branch September 8, 2020 17:48
@ericgopak
Copy link

This change can break some builds (if used library version differ from the default ones).
I'm surprised this was added in Capacitor 2.4.1. Didn't expect my build to fail after upgrading from 2.4.0 🤷‍♂️
(I know, I should have checked the release notes)

Anyway, thanks for the improvement! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcesarmobile @ericgopak @imhoffd