-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add WebColor utility for parsing color #3947
Conversation
On iOS users can use RGB or RGBA indistinctly, so this should behave the same way. |
Summary of slack conversation: don't extend |
android/capacitor/src/main/java/com/getcapacitor/util/WebColor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I will merge this when the plugin PR goes up later today |
Under
package main.java.com.getcapacitor.util;
Uses
Color.parseColor
under the hood but allows the user to specify an ColorFormat. Right now only RGB, RGBA and ARGB are supported. But it would be cool to add something like HSV or HSL in the future.Fixes #3903 (but will require changes to a bunch of the plugins)