Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): init failure if config.xml is present #4224

Closed
wants to merge 4 commits into from
Closed

fix(cli): init failure if config.xml is present #4224

wants to merge 4 commits into from

Conversation

jcesarmobile
Copy link
Member

For some unknown reason, parseStringPromise is failing only when you install from npm or from npm pack, but not if installed locally or linked

The PR uses the callback based parseString that seems to work fine.

closes #4223

@imhoffd imhoffd mentioned this pull request Feb 19, 2021
Merged
@imhoffd
Copy link
Contributor

imhoffd commented Feb 19, 2021

Alternative: #4227

@jcesarmobile
Copy link
Member Author

closing in favor of #4227

@jcesarmobile jcesarmobile deleted the fix-config-read branch February 19, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd Awaiting requested review from imhoffd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: [Cap 3 beta] cap init fails in Cordova project with config.xml file
2 participants
@jcesarmobile @imhoffd