feat(android): Enable Kotlin for Cordova Android Plugins #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2021
|
You can have downstream projects using Kotlin as a dependency or are even written using Gradle Kotlin DSL without this. While the current Groovy-based Gradle files can certainly be improved to simplify using Gradle Kotlin DSL in your own projects, this change doesn't solve anything. |
|
@saschpe it solves this for example for the usage of https://github.com/EinfachHans/cordova-plugin-advanced-imagepicker |
saschpe
reviewed
Oct 27, 2021
| @@ -13,6 +13,9 @@ buildscript { | |||
| } | |||
|
|
|||
| apply plugin: 'com.android.library' | |||
| if(project.hasProperty('kotlin_version')) { | |||
There was a problem hiding this comment.
Not every Gradle project that has a dependency on Kotlin sets this property.
|
Closing as a similar PR was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4426
If
kotlin_versionis set (because Kotlin is configured in module) the capacitor-cordova-android-plugins module now also respects that and configures itself.