-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support capacitor portals plugin changes needed #5558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice and clean 👍
@jcesarmobile Brought up the point that we might use hooks from plugins rather than having the copy code in CLI core. We discussed this as a group and feel like that might cause more issues moving forward. Hooks for platforms makes more sense because the code mods are only controlled by a single codebase. Electron/iOS/Android. But in the case of allowing for code mods or hooks from Plugins we run into issues. These hooks can introduce unpredictable side effects. Where the order of plugin loading can yield different results and individual plugins can cause major issues with projects without devs realizing this in the usage. For this case we believe it is best to continue with this simplistic approach of having the code mods in the CLI core codebase. |
No description provided.