feat(android/cli): Allow to use the old addJavascriptInterface bridge #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
commented
Oct 31, 2022
| @@ -123,12 +122,12 @@ public void sendResponseMessage(PluginCall call, PluginResult successResult, Plu | |||
|
|
|||
| boolean isValidCallbackId = !call.getCallbackId().equals(PluginCall.CALLBACK_ID_DANGLING); | |||
| if (isValidCallbackId) { | |||
| if (WebViewFeature.isFeatureSupported(WebViewFeature.WEB_MESSAGE_LISTENER) && javaScriptReplyProxy != null) { | |||
| if (bridge.getConfig().isUsingLegacyBridge()) { | |||
There was a problem hiding this comment.
I had to use an extra if because Android Studio would complain if I put this check with ! on the isFeatureSupported check on the postMessage line
jcesarmobile
requested review from
IT-MikeS,
giralte-ionic,
ItsChaceD and
theproducer
giralte-ionic
approved these changes
Oct 31, 2022
IT-MikeS
approved these changes
Nov 2, 2022
This comment was marked as abuse.
This comment was marked as abuse.
piotr-cz
reviewed
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5949