fix(iOS): Separate cookies by ; rather than ; when accessing through document.cookie
#6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhayes
changed the title
; rather than ;; rather than ; when accessing through document.cookie
ItsChaceD
approved these changes
Feb 20, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ItsChaceD
approved these changes
Feb 20, 2023
This comment was marked as abuse.
This comment was marked as abuse.
giralte-ionic
approved these changes
Mar 9, 2023
|
@crhayes please merge with |
|
@giralte-ionic Done! Ready for merge, thanks! Is this something you think would make it to the next patch/minor release, or would this be released with Capacitor 5? |
|
@crhayes |
markemer
pushed a commit
that referenced
this pull request
Apr 17, 2023
…ough `document.cookie` (#6313) Co-authored-by: Chace Daniels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6308