fix(ios): add some new cordova-ios classes used by Cordova plugins #7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example repo here: https://github.com/bosh-code/cordova-iab-6-example |
jcesarmobile
approved these changes
Dec 4, 2023
jcesarmobile
changed the title
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
IT-MikeS
approved these changes
Dec 4, 2023
jcesarmobile
added a commit
that referenced
this pull request
Dec 4, 2023
…7096) Co-authored-by: jcesarmobile <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cordova plugin: cordova-plugin-inappbrowser was recently updated to 6.0.0.
On iOS it now requires an additional file from CordovaLib that Capacitor does not currently provide, see: changes and the file
This PR adds the required files (copied from here) to
CapacitorCordovaios.I have tested this on an existing project that uses
cordova-plugin-inappbrowser, by manually editing theCapacitorCordovadevelopment pod to include these files and it works correctly.