chore: include proper template folders for swiftlint #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
Steven0351,
andredestro,
markemer,
EiyuuZack,
Chuckytuh,
theproducer and
usernuno
jcesarmobile
changed the title
markemer
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ios template was renamed last year but the path in
swiftlint.config.jswas not adjusted and also the SPM template was not added, so corrected the path and added the SPM path too.Then ran
npm run fmtwith swiftlint 0.57.0 and it made those changes.We have some tests folders in the excluded lists, not sure why, but not the
CodableTestsfolders, not sure if we want to exclude that too, or remove the exclusion of the other tests folders.