chore(ionic): update to v7

[brandyscarney]

• updates to Ionic v7
• does NOT update input syntax

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
docs-demo	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 29, 2023 at 5:03PM (UTC)

[liamdebeasi]

DOCS: It is not clear how swipeToClose becomes canDismiss for the card modal

In this case you can just remove swipeToClose since card modals are swipeable by default. If you wanted to prevent swiping then you can use canDismiss. I'll update the migration guide to clarify this.

edit: PR ionic-team/ionic-docs#2839

DOCS: Where is the documentation for the input syntax changes?

Input syntax changes are here: https://ionicframework.com/docs/v7/api/input#migrating-from-legacy-input-syntax

BUG: In the datetime example, in md mode, the bottom of the Location is cutoff (exists in v6 too)

If you use the new input syntax then the highlight goes away inside of ion-item.

[brandyscarney]

Input syntax changes are here: https://ionicframework.com/docs/v7/api/input#migrating-from-legacy-input-syntax

Can we add this (and the checkbox, toggle, etc.) somewhere in the migration guide here: https://ionicframework.com/docs/v7/updating/7-0

There are warnings in the console about it but it's kind of hard to find these docs

[liamdebeasi]

I don't think adding them to the migration guide is the right call here. The migration guide only notes the changes that developers need to make in order to have a working version of Ionic 7. The input syntax changes are optional at the moment, so devs don't need to make those changes.

Would it help if we linked to the docs from the console warning?

[brandyscarney]

Would it help if we linked to the docs from the console warning?

Yeah that would be fine

[liamdebeasi]

Code looks good. We don't need to make the input syntax changes right now, but if you have time and want to do it feel free.

[brandyscarney]

I was going to do the input syntax changes but I am not sure how to approach some of them, like this:

docs-demo/src/components/input/input.tsx

Lines 53 to 60 in 56b246d

	<ion-item>
	<ion-label position="stacked">Address</ion-label>
	<ion-input placeholder="Address Line 1"></ion-input>
	<ion-input placeholder="Address Line 2"></ion-input>
	<ion-input placeholder="City"></ion-input>
	<ion-input placeholder="State"></ion-input>
	<ion-input placeholder="Zip Code"></ion-input>
	</ion-item>

Want me to make a tech debt ticket for this and leave it for now?

[liamdebeasi]

Sure you can make a tech debt ticket. For those inputs you'd want to add an aria-label to each and that should be sufficient.

[brandyscarney]

Done: https://ionic-cloud.atlassian.net/browse/FW-3796

Is our plan to merge these immediately or wait until the 7.0 release?

[liamdebeasi]

You can merge this now because the main deployment is configured to only show up on the v7 docs.

[brandyscarney]

Okay do you want me to change the version to 7.0.0 for when it is released or wait?

[liamdebeasi]

If you want to merge now then we'll need to wait on bumping to 7.0.0 otherwise the build will fail (since 7.0.0 is not out yet). Given how close we are to release, I'm fine just waiting to merge until release day.