-
Notifications
You must be signed in to change notification settings - Fork 303
ionic serve freezes if manifest.json is missing #224
Comments
Maybe this is related? I have no manifest.json, and on Windows i have the same problem: |
Possibly, I'm also on Windows. |
Hello, thanks for using Ionic! Would you mind sharing the reason you are deleting the manifest.json? |
I don't remember why I removed it, it was weeks ago. Most likely because it's a hybrid app and it wasn't going to be deployed as a PWA. I've added it back now, but it took me a while to find out why ionic serve was freezing after updating to 0.0.37. |
Hello all! So after some debugging this morning this has exposed where we need some better error handling in our copy script. The copy script fails (silently) and then breaks the watch task from ever fully starting. I am looking into making sure that when the copy script runs into a file that is not their that it A: throws a warning and then continues to the next path in the array, B: does not break things in the build down the line. |
I am tracking this is issue here so I am going to close this. Thanks, |
I moved manifest.json from where I had it to the root of src and can confirm that |
Why did you close this issue ? it's still an error at 0.0.38 |
What is the error that you're seeing? Thanks, |
I've just added 2 files to src , the manifest and service worker .js and now build is working , before the build process is stack with error on "can't find files" ... I wonder since which version it is a must to add the files into src ? |
@macdasi, It shouldn't prevent the build from going through either way. That is a bug on our end if that is the case. It should just report the issue and continue on. Thanks, |
It prevents |
@macdasi, are you on windows? I just tested this on my Mac and Node 4.x LTS and it works as expected. Thanks, |
windows 7 On Mon, Oct 31, 2016 at 6:23 PM, Dan Bucholtz [email protected]
|
@macdasi, cool, I think this is a Windows only issue. I'll fire up my Windows instance and test it out. Thanks, |
Short description of the problem:
If you delete the
src/manifest.json
file,ionic serve
freezes afterbuild dev finished in ...
line.What behavior are you expecting?
ionic serve
not freezingSteps to reproduce:
src/manifest.json
.@ionic/[email protected]
(the bug doesn't seem to happen with 0.0.36)ionic serve
Which @ionic/app-scripts version are you using?
@ionic/[email protected]
The text was updated successfully, but these errors were encountered: