ionic serve freezes if manifest.json is missing

[imgx64]

Short description of the problem:

If you delete the src/manifest.json file, ionic serve freezes after build dev finished in ... line.

What behavior are you expecting?

ionic serve not freezing

Steps to reproduce:

1. Create a new Ionic v2 starter project.
2. delete src/manifest.json.
3. install @ionic/[email protected] (the bug doesn't seem to happen with 0.0.36)
4. run ionic serve

Which @ionic/app-scripts version are you using?
@ionic/[email protected]

[chrste90]

Maybe this is related? I have no manifest.json, and on Windows i have the same problem:
#199

[imgx64]

Possibly, I'm also on Windows.

[jgw96]

Hello, thanks for using Ionic! Would you mind sharing the reason you are deleting the manifest.json?

[imgx64]

I don't remember why I removed it, it was weeks ago. Most likely because it's a hybrid app and it wasn't going to be deployed as a PWA. I've added it back now, but it took me a while to find out why ionic serve was freezing after updating to 0.0.37.

[jgw96]

Hello all! So after some debugging this morning this has exposed where we need some better error handling in our copy script. The copy script fails (silently) and then breaks the watch task from ever fully starting. I am looking into making sure that when the copy script runs into a file that is not their that it A: throws a warning and then continues to the next path in the array, B: does not break things in the build down the line.

[danbucholtz]

I am tracking this is issue here so I am going to close this.

#246

Thanks,
Dan

[morrisonbrett]

I moved manifest.json from where I had it to the root of src and can confirm that ionic serve is no longer hanging on 0.0.37-2 on Windows 10.

[macdasi]

Why did you close this issue ? it's still an error at 0.0.38

[danbucholtz]

@macdasi,

What is the error that you're seeing?

Thanks,
Dan

[macdasi]

I've just added 2 files to src , the manifest and service worker .js and now build is working , before the build process is stack with error on "can't find files" ... I wonder since which version it is a must to add the files into src ?

[danbucholtz]

@macdasi, It shouldn't prevent the build from going through either way. That is a bug on our end if that is the case. It should just report the issue and continue on.

Thanks,
Dan

[macdasi]

It prevents

[danbucholtz]

@macdasi, are you on windows? I just tested this on my Mac and Node 4.x LTS and it works as expected.

Thanks,
Dan

[macdasi]

windows 7

On Mon, Oct 31, 2016 at 6:23 PM, Dan Bucholtz [email protected]
wrote:

@macdasi https://github.com/macdasi, are you on windows? I just tested
this on my Mac and Node 4.x LTS and it works as expected.

Thanks,
Dan

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#224 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGE2MbwJGACRmJkJExnhuw0SG0317KZlks5q5hYBgaJpZM4Keh5A
.

[danbucholtz]

@macdasi, cool, I think this is a Windows only issue. I'll fire up my Windows instance and test it out.

Thanks,
Dan