Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change comments for pwa-elements defineCustomElements #3191

Merged
merged 1 commit into from
Oct 30, 2023
Merged

docs: change comments for pwa-elements defineCustomElements #3191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/angular/your-first-app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Next, import `@ionic/pwa-elements` by editing `src/main.ts`.
```tsx
import { defineCustomElements } from '@ionic/pwa-elements/loader';

// Call the element loader after the platform has been bootstrapped
// Call the element loader before the bootstrapModule/bootstrapApplication call
defineCustomElements(window);
```

Expand Down
2 changes: 1 addition & 1 deletion docs/react/your-first-app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Next, import `@ionic/pwa-elements` by editing `src/main.tsx`.
```tsx
import { defineCustomElements } from '@ionic/pwa-elements/loader';

// Call the element loader after the platform has been bootstrapped
// Call the element loader before the render call
defineCustomElements(window);
```

Expand Down
2 changes: 0 additions & 2 deletions docs/vue/your-first-app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ Next, import `@ionic/pwa-elements` by editing `src/main.ts`.
```tsx
// Above the createApp() line
import { defineCustomElements } from '@ionic/pwa-elements/loader';

// Call the element loader after the platform has been bootstrapped
defineCustomElements(window);
```

Expand Down
Loading