-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(select): avoid duplicate dialogs and backdrops when clicking (#25175
) Resolves #25126
- Loading branch information
1 parent
ff1429b
commit 70d2784
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { expect } from '@playwright/test'; | ||
import { test } from '@utils/test/playwright'; | ||
|
||
test.describe('select: basic', () => { | ||
test('should not open multiple alert windows when clicked multiple times', async ({ page }) => { | ||
test.info().annotations.push({ | ||
type: 'issue', | ||
description: 'https://github.com/ionic-team/ionic-framework/issues/25126', | ||
}); | ||
|
||
await page.goto('/src/components/select/test/basic'); | ||
|
||
const select = page.locator('#gender'); | ||
|
||
await select.evaluate((el: HTMLSelectElement) => { | ||
/* | ||
* Playwright's click() method attempts to scroll to the handle | ||
* to perform the action. That is problematic when the overlay | ||
* is already visible. We manually click() the element instead | ||
* to avoid flaky tests. | ||
*/ | ||
el.click(); | ||
el.click(); | ||
el.click(); | ||
}); | ||
|
||
const alerts = await page.$$('ion-alert'); | ||
|
||
expect(alerts.length).toBe(1); | ||
}); | ||
}); |