-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: rename dark/high-contrast themes to palettes (#29149)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Ionic Framework currently plans to offer dark and high contrast "themes" in v8. However this naming nomenclature conflicts with a significant new feature that the team is working on towards v9+. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Migrates previous dark and high contrast "themes" to "palettes" - Updates test infrastructure to import from the new stylesheet locations ## Does this introduce a breaking change? - [x] Yes - [ ] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> Developers that have updated to the Ionic v8 beta and have implemented the dark and high contrast themes, will need to update the import path: ```diff -@import '@ionic/angular/css/themes/dark.always.css'; +@import '@ionic/angular/css/palettes/dark.always.css'; ``` ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Blocked by: #29148. Review that first. Documentation PR: ionic-team/ionic-docs#3521 --------- Co-authored-by: Liam DeBeasi <[email protected]>
- Loading branch information
1 parent
5577d38
commit 761e1b4
Showing
22 changed files
with
147 additions
and
175 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @import "./dark"; | ||
|
|
||
| :root { | ||
| @include dark-base-palette(); | ||
| } | ||
|
|
||
| :root.ios { | ||
| @include dark-ios-palette(); | ||
| } | ||
|
|
||
| :root.md { | ||
| @include dark-md-palette(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @import "./dark"; | ||
|
|
||
| .ion-palette-dark { | ||
| @include dark-base-palette(); | ||
| } | ||
|
|
||
| .ion-palette-dark.ios { | ||
| @include dark-ios-palette(); | ||
| } | ||
|
|
||
| .ion-palette-dark.md { | ||
| @include dark-md-palette(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @import "./high-contrast-dark"; | ||
|
|
||
| :root { | ||
| @include high-contrast-dark-base-palette(); | ||
| } | ||
|
|
||
| :root.ios { | ||
| @include high-contrast-dark-ios-palette(); | ||
| } | ||
|
|
||
| :root.md { | ||
| @include high-contrast-dark-md-palette(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @import "./high-contrast-dark"; | ||
|
|
||
| .ion-palette-high-contrast.ion-palette-dark { | ||
| @include high-contrast-dark-base-palette(); | ||
| } | ||
|
|
||
| .ion-palette-high-contrast.ion-palette-dark.ios { | ||
| @include high-contrast-dark-ios-palette(); | ||
| } | ||
|
|
||
| .ion-palette-high-contrast.ion-palette-dark.md { | ||
| @include high-contrast-dark-md-palette(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @import "./high-contrast"; | ||
|
|
||
| :root { | ||
| @include high-contrast-light-base-palette(); | ||
| } | ||
|
|
||
| :root.md { | ||
| @include high-contrast-light-md-palette(); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @import "./high-contrast"; | ||
|
|
||
| .ion-palette-high-contrast { | ||
| @include high-contrast-light-base-palette(); | ||
| } | ||
|
|
||
| .ion-palette-high-contrast.md { | ||
| @include high-contrast-light-md-palette(); | ||
| } |
Oops, something went wrong.