feat(events): handler argument is optional in unsubscribe()

fixes #8235
ionic-team · Sep 30, 2016 · 8878e70 · 8878e70
1 parent 607ceef
commit 8878e70
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/navigation/nav-controller-base.ts b/src/navigation/nav-controller-base.ts
@@ -959,4 +959,4 @@ let ctrlIds = -1;
 
 const DISABLE_APP_MINIMUM_DURATION = 64;
 const ACTIVE_TRANSITION_MAX_TIME = 5000;
-const ACTIVE_TRANSITION_OFFSET = 200;
+const ACTIVE_TRANSITION_OFFSET = 200;
diff --git a/src/util/events.ts b/src/util/events.ts
@@ -55,7 +55,7 @@ export class Events {
    *
    * @return true if a handler was removed
    */
-  unsubscribe(topic: string, handler: Function) {
+  unsubscribe(topic: string, handler: Function = null) {
     let t = this._channels[topic];
     if (!t) {
       // Wasn't found, wasn't removed