Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: IonReorder items animate twice in Firefox #21182

Closed
mtrosenstein opened this issue May 1, 2020 · 7 comments · Fixed by #26326
Closed

bug: IonReorder items animate twice in Firefox #21182

mtrosenstein opened this issue May 1, 2020 · 7 comments · Fixed by #26326
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@mtrosenstein
Copy link

Bug Report

Ionic version:
5.x

Current behavior:

With IonReorder, when a user drags an item to a new location the "displaced" items use a translateY animation to reposition themselves. When the dragged item is released, the displaced items animate a second time, even though they are already positioned correctly. The user experience is that some items "jump" unexpectedly.

Expected behavior:

The translateY animation should only run only once, with no "jump" when the reorder completes.

Steps to reproduce:

The easiest way to reproduce is to view the official ion-reorder example. Click the "Toggle" text to enable reordering. Next, slowly drag "Item 1" to the location of "Item 4". Notice how the other items translate to their new locations. Then release "Item 1" in its final location and notice how the other items animate again.

@ionitron-bot ionitron-bot bot added the triage label May 1, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. What browser/version are you testing this on? I am not seeing this on Chrome 81.

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label May 1, 2020
@ionitron-bot ionitron-bot bot removed the triage label May 1, 2020
@mtrosenstein
Copy link
Author

Ahh, good question. I see the problem on Firefox 75.0.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels May 1, 2020
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels May 1, 2020
@ionitron-bot ionitron-bot bot removed the triage label May 1, 2020
@liamdebeasi liamdebeasi changed the title bug: IonReorder items animate twice bug: IonReorder items animate twice in Firefox May 1, 2020
@wibed
Copy link

wibed commented Nov 2, 2020

I can confirm the bug persists on Firefox 82 on osx

I can't say if it animates twice, but it looks like bouncing back even if the array passed, is reordered correctly.
using undefined on complete will work as expected
on safari it animates as expected

@duerra
Copy link

duerra commented Jun 28, 2021

I can confirm the bug is still present as of Firefox 89.

dan-rp1 added a commit to dan-rp1/ionic-framework that referenced this issue Jul 21, 2022
dan-rp1 added a commit to dan-rp1/ionic-framework that referenced this issue Jul 22, 2022
@liamdebeasi liamdebeasi added type: bug a confirmed bug report and removed type: bug a confirmed bug report labels Nov 21, 2022
@liamdebeasi
Copy link
Contributor

Hi there,

I have a dev build with a proposed fix if anyone is interested in testing:

6.3.8-dev.11669044540.14469944

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26326, and a fix will be available in an upcoming release of Ionic Framework. Please feel free to continue testing the dev build, and let me know if you run into any issues.

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 22, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
4 participants