Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add routing support to breadcrumbs #23553

Closed
EinfachHans opened this issue Jul 1, 2021 · 5 comments
Closed

feat: add routing support to breadcrumbs #23553

EinfachHans opened this issue Jul 1, 2021 · 5 comments
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement v6 issues specific to Framework v6

Comments

@EinfachHans
Copy link
Contributor

Feature Request

Ionic version:

[ ] 4.x
[ ] 5.x
[X] 6.x

Describe the Feature Request

The default routerDirection on a <ion-breadcrumb> is currently forward. I think it would be better to determinate that on the active Breadcrumb.

Describe Preferred Solution

If a user clicked on a Breadcrumb that is before the currently active one, the router Direction should be backwards, otherwise forward.

@ionitron-bot ionitron-bot bot added the triage label Jul 1, 2021
@liamdebeasi
Copy link
Contributor

ion-breadcrumb does not make any assumptions about the routing integration and it is up to the user to do that themselves. Do you have a use case for how you are using breadcrumbs right now?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jul 1, 2021
@ionitron-bot ionitron-bot bot removed the triage label Jul 1, 2021
@EinfachHans
Copy link
Contributor Author

I'm not yet using them, but if v6 is stable and i migrate my app i want to use it of course.

Lets say we have 4 Pages which are routed like this:

Page 1 --> Page 2 --> Page 3 --> Page 4

Starting from Page 2 i would use Breadcrumps on every Page to give the user a better overview about where he is and were he was before, so the Setup would be:

on Page 2:
Breadcrumbs: Page1 > Page 2

on Page 3:
Breadcrumbs: Page1 > Page 2 > Page 3

on Page 4:
Breadcrumbs: Page1 > Page 2 > Page 3 > Page 4

If a user wants to navigate back and does this via the Breadcrumbs he should have the feeling of going back, so if he is on Page 4 and choose to go back to Page 1, it should be a backwards direction. As i don't want to add this to every single breadcrum i think it should be default for breadcrums that are before the active one.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jul 1, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the additional information. I think the bigger request here is to add routing integration to the breadcrumbs. Right now, the team is not really in favor of adding that since we don't have enough information to implement it in a way that would be useful to developers, but I am going to keep this issue open for now.

For others interested in this feature, please reply below with your use case. If you don't have a use case but are still interested in seeing this feature, please add an emoji reaction to the original issue instead of commenting "+1" below. Thanks!

@liamdebeasi liamdebeasi added package: core @ionic/core package type: feature request a new feature, enhancement, or improvement labels Jul 1, 2021
@ionitron-bot ionitron-bot bot removed the triage label Jul 1, 2021
@liamdebeasi liamdebeasi changed the title feat: Breadcrumb default routerDirection feat: add routing support to breadcrumbs Jul 1, 2021
@liamdebeasi liamdebeasi added the v6 issues specific to Framework v6 label Jul 6, 2021
@liamdebeasi liamdebeasi added type: feature request a new feature, enhancement, or improvement and removed type: feature request a new feature, enhancement, or improvement labels Jul 16, 2021
@EinfachHans
Copy link
Contributor Author

EinfachHans commented Jan 11, 2022

This is done with 6.0.2: #24493

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 10, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement v6 issues specific to Framework v6
Projects
None yet
Development

No branches or pull requests

2 participants