Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ionic React Breadcrumbs href prop causes full page refresh #24493

Closed
4 of 6 tasks
babycourageous opened this issue Dec 28, 2021 · 4 comments · Fixed by #24509
Closed
4 of 6 tasks

bug: Ionic React Breadcrumbs href prop causes full page refresh #24493

babycourageous opened this issue Dec 28, 2021 · 4 comments · Fixed by #24509
Labels
package: react @ionic/react package type: bug a confirmed bug report

Comments

@babycourageous
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

There currently isn't a routerLink prop on the IonBreadcrumb for Ionic React. It seems the only way to navigate with them is through the href prop which causes a full page refresh and you lose out on animations, etc.

Filing this under bug since it seems other "routing" type components do have a routerLink prop for Ionic React components to take advantage of. But happy to move to Feature Request if that's more appropriate a spot.

Thanks!

Expected Behavior

I think since breadcrumbs are used to route within your app having a routerLink prop for React apps like other routing components so that there isn't a full page refresh when using the breadcrumb.

Steps to Reproduce

You can spin up the repo sample and navigate either to the "list" or "detail" page. If you then use the breadcrumb to navigate back in the tree you will see the full page refresh.

Code Reproduction URL

https://github.com/babycourageous/ionic-breadcrumbs-routing-refresh

Ionic Info

Ionic:

Ionic CLI : 6.18.1 (/Users/renedellefont/.fnm/node-versions/v14.17.6/installation/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 6.0.1

Capacitor:

Capacitor CLI : 3.3.3
@capacitor/android : not installed
@capacitor/core : 3.3.3
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 1.5.0

System:

NodeJS : v14.17.6 (/Users/renedellefont/.fnm/node-versions/v14.17.6/installation/bin/node)
npm : 6.14.15
OS : macOS Big Sur

Additional Information

No response

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Dec 28, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 28, 2021

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!

@sean-perkins sean-perkins self-assigned this Jan 5, 2022
@sean-perkins sean-perkins added package: react @ionic/react package type: bug a confirmed bug report labels Jan 5, 2022
@ionitron-bot ionitron-bot bot removed the holiday triage issues that were created during holiday period label Jan 5, 2022
@sean-perkins
Copy link
Contributor

Thanks for reporting this @babycourageous!

I agree, ion-breadcrumb is a routing component and should have the same behavior as other components with routerLink.

@sean-perkins sean-perkins added type: bug a confirmed bug report and removed type: bug a confirmed bug report labels Jan 5, 2022
@sean-perkins sean-perkins removed their assignment Jan 5, 2022
@babycourageous
Copy link
Contributor Author

Thanks so much for the update @sean-perkins . Oh wow AND PR. Awesome!!

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 9, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: react @ionic/react package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants