Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: type '{ icon: string; }' is not assignable to parameter of type 'ToastOptions'. #23736

Closed
4 of 6 tasks
jongbonga opened this issue Aug 6, 2021 · 2 comments
Closed
4 of 6 tasks
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@jongbonga
Copy link

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

ToastOptions does not include icon as per #23596

export interface ToastOptions {
  header?: string;
  message?: string | IonicSafeString;
  cssClass?: string | string[];
  duration?: number;
  buttons?: (ToastButton | string)[];
  position?: 'top' | 'bottom' | 'middle';
  translucent?: boolean;
  animated?: boolean;
  color?: Color;
  mode?: Mode;
  keyboardClose?: boolean;
  id?: string;
  enterAnimation?: AnimationBuilder;
  leaveAnimation?: AnimationBuilder;
}

Expected Behavior

ToastOptions should be able to get icon

Steps to Reproduce

install latest @ionic/angular 6.0.0-beta.3

Code Reproduction URL

No response

Ionic Info

Ionic:

   Ionic CLI                     : 6.16.3 (/Users/jonathan/.nvm/versions/node/v16.4.2/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 6.0.0-beta.3
   @angular-devkit/build-angular : 12.1.4
   @angular-devkit/schematics    : 12.2.0
   @angular/cli                  : 12.1.4
   @ionic/angular-toolkit        : 4.0.0

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23737, and a fix will be available in an upcoming release of Ionic Framework.

@liamdebeasi liamdebeasi added this to the 6.0.0-beta.4 milestone Aug 9, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 8, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants